Skip to content

Conversation

@nmnobre
Copy link
Contributor

@nmnobre nmnobre commented Nov 25, 2025

Made possible by #196. Does not change semantics, simply reuses code for robustness/conciseness.

@xiaoyeli xiaoyeli merged commit bce5318 into xiaoyeli:master Nov 28, 2025
15 of 16 checks passed
@nmnobre nmnobre deleted the gpu_acc_offload branch November 28, 2025 00:57
@xiaoyeli
Copy link
Owner

@nmnobre Does it solve this problem? - even if you compile the code with GPU enabled (such that GPU_ACC is defined), but you don't want to use GPU offload (i.e., setting superlu_acc_offload=0), then there should be no GPU memory allocated?

@nmnobre nmnobre changed the title Use gpu_acc_offload() where appropriate Use get_acc_offload() where appropriate Nov 28, 2025
@nmnobre
Copy link
Contributor Author

nmnobre commented Nov 28, 2025

even if you compile the code with GPU enabled (such that GPU_ACC is defined), but you don't want to use GPU offload (i.e., setting superlu_acc_offload=0), then there should be no GPU memory allocated?

This was already the case. It's my bad for not realising that offloading was on by default. This PR (and now #207) simply refactored the code for code reuse/readability/conciseness, it does not change the code behaviour whatsoever.

xiaoyeli added a commit to xiaoyeli/superlu_dist_base that referenced this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants