Fix: add 11 missing write ops to exhaustive MCP bridge test#520
Merged
Conversation
The exhaustive_write_operations_not_read_only test was missing 11 write operations defined in core-types.ts, reducing its regression-prevention value. Added: selection.delete, block.toggle, table.addRowBefore, table.addRowAfter, table.deleteRow, table.addColumnBefore, table.addColumnAfter, table.deleteColumn, table.toggleHeaderRow, smartInsert, and insertMedia. Closes #515 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exhaustive_write_operations_not_read_onlytest insrc-tauri/src/mcp_bridge/state.rsselection.delete,block.toggle,table.addRowBefore,table.addRowAfter,table.deleteRow,table.addColumnBefore,table.addColumnAfter,table.deleteColumn,table.toggleHeaderRow,smartInsert,insertMediavmark-mcp-server/src/bridge/core-types.tsbut missing from the regression testCloses #515
Test plan
write_opsarray in the correct categoriescargo test --lib mcp_bridge::state::testspasses (requires sidecar binary)🤖 Generated with Claude Code