Open
Conversation
sipmine
added
ci:covered
sipmine
force-pushed
the
feat/subscription-service
branch
2 times, most recently
from
ae7b5d2 to
bd0fb09
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
force-pushed
the
feat/subscription-service
branch
from
bd0fb09 to
6bf3c9c
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
taaylor
reviewed
Sep 27, 2025
Member
taaylor
left a comment
taaylor
left a comment
There was a problem hiding this comment.
Оставил комменты, если будут вопросы - спрашивай и пингуй в дс
ByrDen
reviewed
Sep 29, 2025
Contributor
ByrDen
left a comment
ByrDen
left a comment
There was a problem hiding this comment.
Выглядит неплохо :)
Старался подробно расписывать, если что-то не понятно, буду рад объяснить в треде таски
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
force-pushed
the
feat/subscription-service
branch
from
42c024e to
6f05218
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
ByrDen
reviewed
Oct 12, 2025
Contributor
ByrDen
left a comment
ByrDen
left a comment
There was a problem hiding this comment.
чуть-чуть нашлось новенького)
sipmine
force-pushed
the
feat/subscription-service
branch
2 times, most recently
from
57f39b9 to
4dc388c
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
force-pushed
the
feat/subscription-service
branch
2 times, most recently
from
05fb9ab to
b513496
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
force-pushed
the
feat/subscription-service
branch
from
6f3020f to
7eaed2d
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
sipmine
force-pushed
the
feat/subscription-service
branch
2 times, most recently
from
59243bd to
c1a8ac5
Compare
sipmine
had a problem deploying
to
manual-staging
GitHub Actions
Failure
niqzart
force-pushed
the
feat/subscription-service
branch
from
c1a8ac5 to
6d72584
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
6d72584 to
e783caf
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
e783caf to
1ee4ca9
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
1ee4ca9 to
0fd7776
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
0fd7776 to
145f361
Compare
ByrDen
reviewed
Jan 23, 2026
Contributor
ByrDen
left a comment
ByrDen
left a comment
There was a problem hiding this comment.
Всё гуд, парочка новых. И один не закрыл - решение ты придумал, но оно около костыльное. Подробности в ДС.
sipmine
force-pushed
the
feat/subscription-service
branch
from
145f361 to
1c9c65f
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
1c9c65f to
908ed8f
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
3 times, most recently
from
87ce1f1 to
ab518d3
Compare
niqzart
reviewed
Feb 21, 2026
| ) | ||
|
|
||
|
|
||
| async def test_promocode_creation_promocode_already_exist( |
Member
There was a problem hiding this comment.
typo(if-minor): exist -> exists, точно также, как в ошибке
| ], | ||
| ) | ||
| async def test_promocode_retrieving_promocode_not_found( | ||
| mub_client: TestClient, path: str, field_by: str |
Member
There was a problem hiding this comment.
polish: запятая на конце позволит сложить это получше
Member
There was a problem hiding this comment.
Аналогично в тестах ниже, где куча аргументов в одну строчку
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("path", "field_by"), |
Member
There was a problem hiding this comment.
polish: field_by нелогичное название ("поле по")
niqzart
reviewed
Feb 21, 2026
| promocodes: list[Promocode] = [ | ||
| await Promocode.create( | ||
| **LimitedPromocodeInputFactory.build_python( | ||
| code=faker.unique.pystr(min_chars=2, max_chars=10) |
Member
There was a problem hiding this comment.
issue(repeat): faker.unique не лучшее решение для большого количества кодов и для глобального faker-а (а он у нас именно такой). Обговаривали, что коды надо генерить так, чтобы они гарантированно генерились разные. Раньше идея была практически корректная, не хватало только нижней границы. Сейчас стало хуже
niqzart
reviewed
Feb 21, 2026
Comment on lines
9
to
27
| @pytest.fixture() | ||
| async def promocode(active_session: ActiveSession) -> Promocode: | ||
| async with active_session(): | ||
| return await Promocode.create( | ||
| **factories.LimitedPromocodeInputFactory.build_python() | ||
| ) | ||
|
|
||
|
|
||
| @pytest.fixture() | ||
| async def promocode_data(promocode: Promocode) -> AnyJSON: | ||
| return Promocode.ResponseSchema.model_validate(promocode).model_dump(mode="json") | ||
|
|
||
|
|
||
| @pytest.fixture() | ||
| async def other_promocode(active_session: ActiveSession) -> Promocode: | ||
| async with active_session(): | ||
| return await Promocode.create( | ||
| **factories.LimitedPromocodeInputFactory.build_python() | ||
| ) |
Member
There was a problem hiding this comment.
issue: нет гарантии, что у promocode и other_promocode не совпадут поля code. Это создаёт flaky-тесты
sipmine
force-pushed
the
feat/subscription-service
branch
from
ab518d3 to
836433f
Compare
sipmine
force-pushed
the
feat/subscription-service
branch
from
836433f to
2810a47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ссылка на таск: https://github.com/xi-effect/xi.progress/issues/14