This repository was archived by the owner on Apr 24, 2025. It is now read-only.
45495229: Board background layout#157
Merged
unknownproperty merged 8 commits intostagingfrom Feb 21, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/pkg.module.board/Board.tsx
Outdated
| export const Board: React.FC = () => { | ||
| // Выбранный инструмент | ||
| const [selectedTool, setSelectedTool] = useState<ToolType>('pen'); | ||
| const [stagePos, setStagePos] = useState<StagePositionT>({ x: 0, y: 0 }); |
Contributor
There was a problem hiding this comment.
Не стоит ли вынести в стор? (Я сам не уверен)
packages/pkg.module.board/Board.tsx
Outdated
|
|
||
| const handleWheel = useWheelZoom(stageRef); | ||
|
|
||
| const debouncedSetStagePos = useDebounce((x, y) => { |
Contributor
There was a problem hiding this comment.
Вообще у нас где-то был этот хук, может стоит поискать, или вынести в общий пакет
| }; | ||
|
|
||
| export const BackgroundLayer = ({ stagePos, scaleValue }: BackgroundLayerPropsT) => { | ||
| const gridStep = 40; |
Contributor
There was a problem hiding this comment.
Выглядит как константа, которую надо вынести вне компонента
|
|
||
| export const BackgroundLayer = ({ stagePos, scaleValue }: BackgroundLayerPropsT) => { | ||
| const gridStep = 40; | ||
| const [viewport, setViewport] = useState({ width: 0, height: 0 }); |
apps/xi.front/package.json
Outdated
| "private": true, | ||
| "scripts": { | ||
| "dev": "next dev --turbopack --port 3000", | ||
| "dev": "next dev --port 3000", |
Contributor
There was a problem hiding this comment.
А почему тут исчез turbopack?
unknownproperty
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.