Implement mouse scrolling for single and double page style navigation#318
Open
syang44 wants to merge 1 commit intoxgi:masterfrom
Open
Implement mouse scrolling for single and double page style navigation#318syang44 wants to merge 1 commit intoxgi:masterfrom
syang44 wants to merge 1 commit intoxgi:masterfrom
Conversation
Owner
|
This has an issue where if the page is long / not constrained by window height (i.e. you only see one page but there's still a scrollbar), scrolling will cause it to go to the next page even if you just want to get to the bottom of the image. Think there'd need to be logic to check if the user is scrolling down while at the bottom (or vice versa). I'm not sure if that's easy to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented mouse scrolling for single and double page style navigation. Scroll down navigates to the next pages and vice versa.
Fixes #237