Skip to content

Implement mouse scrolling for single and double page style navigation#318

Open
syang44 wants to merge 1 commit intoxgi:masterfrom
syang44:mouse-scroll
Open

Implement mouse scrolling for single and double page style navigation#318
syang44 wants to merge 1 commit intoxgi:masterfrom
syang44:mouse-scroll

Conversation

@syang44
Copy link

@syang44 syang44 commented Dec 4, 2023

Implemented mouse scrolling for single and double page style navigation. Scroll down navigates to the next pages and vice versa.

Fixes #237

@xgi
Copy link
Owner

xgi commented Dec 19, 2023

This has an issue where if the page is long / not constrained by window height (i.e. you only see one page but there's still a scrollbar), scrolling will cause it to go to the next page even if you just want to get to the bottom of the image.

Think there'd need to be logic to check if the user is scrolling down while at the bottom (or vice versa). I'm not sure if that's easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mouse scrolling for single and double page style navigation

2 participants