Modernise extract-target pass #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not correct in the previous version
… function. Otherwise, the function will not be present in the symbol table of the calling module
…rated IR does not pass the mlir-opt verifier. Tested on all the offload examples
mesham
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernises the pre-exising extract-target pass to be compliant with the new xDSL's API: some operations have changed their name or include new properties. Note that there was a fundamental problem with the location of the bounds in the new function block that was not correct in the previous version. Corrected here.
The pass has been tested with the examples under
examples/omp/offloadwithxftn <ex.F90> --offload -e extract-target.