Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #53 +/- ##
==========================================
+ Coverage 81.91% 83.21% +1.29%
==========================================
Files 37 43 +6
Lines 4170 4564 +394
==========================================
+ Hits 3416 3798 +382
- Misses 754 766 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
SampledCoordinatecoordinate type with fixed sampling interval.This coordinate types is more similar to what used in seismology: one unique sampling rate, several starts associated with number of continuous points.
This new coordinate type is closer to the original data layout, have a better defined unique sampling interval but does not natively deals with gaps and overlaps. Those are determined a posteriori using a given tolerance.
This PR make some important refactoring of the Coordinate part by making defining a clearer API that every coordinate type must follow
InterpCoordinatedis still the default for now, but the user can chose to try this coordinate system by using thectypekwarg:TODO: