Bug fix - automatic software raid install using answerfile#52
Open
jjuanar wants to merge 1 commit intoxcp-ng:10.10.29-8.3from
Open
Bug fix - automatic software raid install using answerfile#52jjuanar wants to merge 1 commit intoxcp-ng:10.10.29-8.3from
jjuanar wants to merge 1 commit intoxcp-ng:10.10.29-8.3from
Conversation
…cally when checking disk block size to take into consideration software raid disks that hasn't been created yet. This patch sends the results of parseRaid into parseDisk so that the md devices can be ignored in the initial check and have the device children checked for block size instead, while still reporting the md device's future block size (since the code checks if the block size is over 512 if any children is over 512 then the md device when created later on must be over 512) Signed-off-by: jjuanar <jjuan@aquaray.com>
rzr
previously approved these changes
Dec 17, 2025
glehmann
previously approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug in question happens when the code tries to check the
logical_block_sizeof the md device that wasn't created yet.To reproduce the bug install xcp-ng via pxe and answerfile while using the raid drive as a primary drive and not turning off sr storage on said drive.
Updated the way disks are parsed when selecting
SR_TYPE, more specifically when checking disk block size to take into consideration software raid disks that hasn't been created yet.This patch sends the results of
parseRaid()intoparseDisk()so that the md devices can be ignored in the initial check and have the device's children checked for block size instead, while still reporting the md device's future block size (since the code checks if the block size is over 512, if any children is over 512 then the md device when created later on must be over 512)Example answerfile: