fix(parser): prevent chunk from being garbage collected#3
Open
digitcrusher wants to merge 1 commit intoxcb-xwii:masterfrom
Open
fix(parser): prevent chunk from being garbage collected#3digitcrusher wants to merge 1 commit intoxcb-xwii:masterfrom
digitcrusher wants to merge 1 commit intoxcb-xwii:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding a reference to the bytes of a string value which was popped off the stack is not safe since the data is now eligible to be freed by the garbage collector. Although this use-after-free bug is most prominent in a Lua interpreter with multiple threads of execution, it might also happen in a single-threaded one. This hypothesis is backed by section 4.1.3 "Pointers to Strings" of the Lua reference manual: