-
Notifications
You must be signed in to change notification settings - Fork 0
[FIX] test dependencies #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors event naming and access modifiers while updating test fixtures and dependencies. The key changes include renaming UI event and error state types, converting sealed classes to sealed interfaces, and modifying coroutine collection behavior in the composable functions.
Reviewed Changes
Copilot reviewed 26 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| presentation/users/src/main/kotlin/com/random/users/users/screen/UsersScreen.kt | Refactored event types in UI state functions |
| presentation/users/src/main/kotlin/com/random/users/users/navigation/UsersRoute.kt | Changed sealed class to sealed interface for navigation routes |
| presentation/users/src/main/kotlin/com/random/users/users/mapper/UsersErrorsMapper.kt | Updated error mapping to align with renamed error state |
| presentation/users/src/main/kotlin/com/random/users/users/contract/UsersScreenContract.kt | Updated contracts to reflect new event and error state naming |
| presentation/users/src/main/kotlin/com/random/users/users/composable/UserSearchView.kt | Added flow-based search handling with LaunchedEffect and snapshotFlow |
| presentation/users/src/main/kotlin/com/random/users/users/composable/UserList.kt | Switched to collectLatest when loading additional users |
| domain/src/test/... | Updated test classes and helper objects with internal modifiers |
| data/src/test/... | Adjusted tests and mother objects' visibility modifiers |
| core/presentation/src/main/kotlin/com/random/user/presentation/navigation/BaseNavRoutes.kt | Converted sealed class to sealed interface for navigation |
| app/src/main/kotlin/com/random/user/navigation/RandomUsersNavHost.kt | Removed redundant theme import |
Files not reviewed (8)
- core/api/build.gradle.kts: Language not supported
- core/database/build.gradle.kts: Language not supported
- core/preferences/build.gradle.kts: Language not supported
- core/test/.gitignore: Language not supported
- core/test/build.gradle.kts: Language not supported
- core/test/proguard-rules.pro: Language not supported
- data/build.gradle.kts: Language not supported
- presentation/users/build.gradle.kts: Language not supported
Deleted core:test (need to see test fixtures)
Moved test di modules to feature