-
Notifications
You must be signed in to change notification settings - Fork 0
[RELEASE] New version 1.2.0 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-improvements [FEATURE] User refactor and improvements
[FEATURE] Integration tests
[FEATURE] Final version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the upcoming release by updating several dependency injection modules to support explicit dispatcher injection and enhancing test configurations. Key changes include:
- Introducing DispatchersModule to provide a CoroutineDispatcher and updating data sources to receive an injected dispatcher.
- Updating DI modules (DataModule, ApiModule) and corresponding test modules for preferences, database, and API.
- Bumping app version codes/names and refining the README and CI workflow for better clarity and consistency.
Reviewed Changes
Copilot reviewed 44 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| data/src/main/kotlin/com/random/users/data/di/DispatchersModule.kt | New module to supply a dispatcher instance for DI. |
| data/src/main/kotlin/com/random/users/data/di/DataModule.kt | Updated functions receive a CoroutineDispatcher parameter. |
| data/src/main/kotlin/com/random/users/data/datasource/UsersDatabaseDataSource.kt | Removed default dispatcher injection to use the provided instance. |
| data/src/main/kotlin/com/random/users/data/datasource/UsersApiDataSource.kt | Similar update for dispatcher injection; simplified lambda style. |
| data/src/main/kotlin/com/random/users/data/datasource/SeedPreferencesDataSource.kt | Updated dispatcher injection pattern. |
| core/test/src/main/kotlin/com/random/users/test/rules/DispatcherRules.kt | Package correction for test rules. |
| core/preferences/src/main/kotlin/com/random/users/preferences/di/TestPreferencesModule.kt | Test module for SharedPreferences updated. |
| core/database/src/main/kotlin/com/random/users/database/di/TestDatabaseModule.kt | New test module for the in-memory database. |
| core/api/src/main/kotlin/com/random/users/api/di/TestApiModule.kt | Adds DI for a MockWebServer-based Retrofit instance with logging. |
| core/api/src/main/kotlin/com/random/users/api/di/ApiModule.kt | Configures OkHttpClient timeouts based on the new TIMEOUT_SECONDS constant. |
| core/api/src/main/kotlin/com/random/users/api/api/UsersApi.kt | Introduces TIMEOUT_SECONDS constant for timeout configuration. |
| buildSrc/src/main/kotlin/AppVersions.kt | Updated application version code and version name. |
| README.md | Revised feature descriptions and repository URL. |
| .github/workflows/check-tests.yml | Added GitHub Actions workflow for running Android tests. |
Files not reviewed (6)
- core/api/build.gradle.kts: Language not supported
- core/database/build.gradle.kts: Language not supported
- core/preferences/build.gradle.kts: Language not supported
- core/presentation/build.gradle.kts: Language not supported
- core/test/build.gradle.kts: Language not supported
- data/build.gradle.kts: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.