Skip to content

Conversation

@xavierpellvidal
Copy link
Owner

No description provided.

@xavierpellvidal xavierpellvidal self-assigned this Apr 22, 2025
@xavierpellvidal xavierpellvidal requested a review from Copilot April 22, 2025 20:42
@xavierpellvidal xavierpellvidal changed the title [RELEASE]  [RELEASE] New version 1.2.0 Apr 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the upcoming release by updating several dependency injection modules to support explicit dispatcher injection and enhancing test configurations. Key changes include:

  • Introducing DispatchersModule to provide a CoroutineDispatcher and updating data sources to receive an injected dispatcher.
  • Updating DI modules (DataModule, ApiModule) and corresponding test modules for preferences, database, and API.
  • Bumping app version codes/names and refining the README and CI workflow for better clarity and consistency.

Reviewed Changes

Copilot reviewed 44 out of 50 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
data/src/main/kotlin/com/random/users/data/di/DispatchersModule.kt New module to supply a dispatcher instance for DI.
data/src/main/kotlin/com/random/users/data/di/DataModule.kt Updated functions receive a CoroutineDispatcher parameter.
data/src/main/kotlin/com/random/users/data/datasource/UsersDatabaseDataSource.kt Removed default dispatcher injection to use the provided instance.
data/src/main/kotlin/com/random/users/data/datasource/UsersApiDataSource.kt Similar update for dispatcher injection; simplified lambda style.
data/src/main/kotlin/com/random/users/data/datasource/SeedPreferencesDataSource.kt Updated dispatcher injection pattern.
core/test/src/main/kotlin/com/random/users/test/rules/DispatcherRules.kt Package correction for test rules.
core/preferences/src/main/kotlin/com/random/users/preferences/di/TestPreferencesModule.kt Test module for SharedPreferences updated.
core/database/src/main/kotlin/com/random/users/database/di/TestDatabaseModule.kt New test module for the in-memory database.
core/api/src/main/kotlin/com/random/users/api/di/TestApiModule.kt Adds DI for a MockWebServer-based Retrofit instance with logging.
core/api/src/main/kotlin/com/random/users/api/di/ApiModule.kt Configures OkHttpClient timeouts based on the new TIMEOUT_SECONDS constant.
core/api/src/main/kotlin/com/random/users/api/api/UsersApi.kt Introduces TIMEOUT_SECONDS constant for timeout configuration.
buildSrc/src/main/kotlin/AppVersions.kt Updated application version code and version name.
README.md Revised feature descriptions and repository URL.
.github/workflows/check-tests.yml Added GitHub Actions workflow for running Android tests.
Files not reviewed (6)
  • core/api/build.gradle.kts: Language not supported
  • core/database/build.gradle.kts: Language not supported
  • core/preferences/build.gradle.kts: Language not supported
  • core/presentation/build.gradle.kts: Language not supported
  • core/test/build.gradle.kts: Language not supported
  • data/build.gradle.kts: Language not supported

@xavierpellvidal xavierpellvidal merged commit 0bbd8e7 into main Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants