Skip to content

Conversation

@xavierpellvidal
Copy link
Owner

@xavierpellvidal xavierpellvidal commented Apr 22, 2025

Refactored some tests
Added workflow for tests
Bump project version

@xavierpellvidal xavierpellvidal self-assigned this Apr 22, 2025
@xavierpellvidal xavierpellvidal requested a review from Copilot April 22, 2025 20:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR finalizes the implementation of new features and updates testing flows, configuration, and documentation for the Android app.

  • Updated unit tests to use shared PAGE and RESULTS constants and added additional verification for UI state events.
  • Revised repository and use case tests for consistency, updated version codes, and enhanced documentation with updated feature details and integration tests.
  • Added a new GitHub Actions workflow to check tests on push and PR builds.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
presentation/users/src/test/kotlin/com/random/users/users/viewmodel/UsersViewModelUnitTest.kt Added experimental coroutine testing and refined assertions for UI state events.
domain/src/test/kotlin/com/random/users/domain/usecase/GetUserListUseCaseUnitTest.kt Replaced literal pagination values with PAGE/RESULTS constants in tests.
data/src/test/kotlin/com/random/users/data/repository/UsersRepositoryUnitTest.kt Updated remote data source tests to use shared constants for pagination.
buildSrc/src/main/kotlin/AppVersions.kt Incremented application version code and version name.
README.md Updated feature list details and corrected the repository clone URL.
.github/workflows/check-tests.yml Introduced a new workflow to run tests on pushes and pull requests.

@xavierpellvidal xavierpellvidal merged commit 21258bd into develop Apr 22, 2025
1 check passed
@xavierpellvidal xavierpellvidal deleted the feature/final-version branch April 22, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants