This repository was archived by the owner on Mar 30, 2020. It is now read-only.
Enable the reverse to reach the backend on AWS#15
Open
alainperry wants to merge 2 commits intoxataz:masterfrom
Open
Enable the reverse to reach the backend on AWS#15alainperry wants to merge 2 commits intoxataz:masterfrom
alainperry wants to merge 2 commits intoxataz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the generated config used the backend container's name as the hostname to forward requests to. On AWS, this didn't work: you need to create a link and since you can't anticipate the name of the running container, the alias of the link is pretty much guaranteed not to be the backend's hostname. This change reads the reverse config to find the alias given by the user to the backend container, which is indeed resolvable and makes it all work.
Disclaimer: I didn't get the chance to check if the change breaks things outside of AWS, since I don't have access to an infrastructure that would allow me to do so. My guess is it won't as long as a link is setup from the reverse to the backend.