Improve error handling and add comprehensive unit tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
xarbit
commented
Dec 1, 2025
xarbit
commented
- Remove redundant eprintln! calls from main.rs (log::error! already handles logging)
- Add comprehensive unit tests for EventHandler (17 new tests):
- Event validation edge cases (whitespace, unicode, long titles)
- EventError display and debug formatting
- Add comprehensive unit tests for CalendarHandler (12 new tests):
- Validation edge cases (empty color, whitespace-only name, unicode)
- CalendarError display and debug formatting
- Default color validation
- Add comprehensive unit tests for ExportHandler (13 new tests):
- iCal export with various fields (location, notes, url, unicode)
- Minimal event export
- ExportError display and debug formatting
- Remove redundant eprintln! calls from main.rs (log::error! already handles logging) - Add comprehensive unit tests for EventHandler (17 new tests): - Event validation edge cases (whitespace, unicode, long titles) - EventError display and debug formatting - Add comprehensive unit tests for CalendarHandler (12 new tests): - Validation edge cases (empty color, whitespace-only name, unicode) - CalendarError display and debug formatting - Default color validation - Add comprehensive unit tests for ExportHandler (13 new tests): - iCal export with various fields (location, notes, url, unicode) - Minimal event export - ExportError display and debug formatting
- validation.rs: 15 tests covering date parsing, title validation, email validation, and date range functions with edge cases - cache.rs: 27 tests covering cache creation, month navigation, precaching, cleanup, and month arithmetic - database/schema.rs: 14 tests covering CRUD operations, multiple calendars, unicode support, and edge cases - protocols/local.rs: 12 tests covering Protocol trait, event operations, and multiple calendar isolation - locale.rs: 31 tests covering 24-hour detection, first day of week, date formats, week range formatting, and day headers Total new tests: ~100 across 5 modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.