coverage: remove dependency on bisect_ppx#6807
Merged
psafont merged 1 commit intoxapi-project:masterfrom Dec 17, 2025
Merged
Conversation
Member
|
I think I was able to use this when working on vTPM, but a lot of that code never made it into master. |
Member
|
We can add it back when the upstream PR for 5.4 support is done |
edwintorok
approved these changes
Dec 17, 2025
last-genius
approved these changes
Dec 17, 2025
This infrastructure has been unused for many years (I think it only ever worked for some months during 2019), and it's making ocaml 5.4 difficult to adopt, so drop it. I'm leaving the instrumentation in the dune metadata because it's disabled by default, and the document about coverage, because it's a historical document. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
psafont
force-pushed
the
dev/pau/nocov
branch
from
b877a1a to
278358b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This infrastructure has been unused for many years (I think it only ever worked for some months during 2019), and it's making ocaml 5.4 difficult to adopt, so drop it.
I'm leaving the instrumentation in the dune metadata because it's disabled by default, and the document about coverage, because it's a historical document.