refactor: use VHD header to fetch block size #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
requested changes
Dec 4, 2025
libs/sm/vhdutil.py
Outdated
| def calcOverheadBitmap(virtual_size): | ||
| num_blocks = virtual_size // VHD_BLOCK_SIZE | ||
| if virtual_size % VHD_BLOCK_SIZE: | ||
| def calcOverheadBitmap(virtual_size, block_size): |
Contributor
There was a problem hiding this comment.
This would probably be better as block_size = DEFAULT_VHD_BLOCKSIZE so that only the call sites that need to pass something other than the default need to be modified. Similarly calcSizeVHDLV in lvhdutil.py should have the same default.
Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Millefeuille42
force-pushed
the
upstream-use-vhd-header-for-block-size
branch
from
0b1884a to
9cdcf61
Compare
MarkSymsCtx
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #719
Fetch block size from VHD header instead of using a hardcoded value. The default hardcoded value of 2MB is still used when creating or in tests.