β‘ Optimize answer randomization in quiz.php #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
ORDER BY rand()from the answers query inquiz_system_git/quiz.php.shuffle()function.rowCount()checks withcount()orfetch()result checks for better portability (fixing issues with SQLite in test environment).π― Why:
ORDER BY rand()is computationally expensive in MySQL as it forces a temporary table sort.π Measured Improvement:
question_idmakes the SELECT fast, exposing the cost ofORDER BY rand()).PR created automatically by Jules for task 10746071036208753713 started by @xRahul