⚡ Optimize ExternalContentBridge contact lookup queries #99
Conversation
- Replaced N+1 ContentProvider queries with batched `IN` clause queries. - Added normalization logic to match fuzzy lookup behavior. - Added Robolectric test to verify query count and logic. Co-authored-by: xRahul <1639945+xRahul@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Replaced the loop-based
PhoneLookupquery mechanism inExternalContentBridge.getContactNameswith a batched query againstContactsContract.CommonDataKinds.Phone.🎯 Why:
The previous implementation performed one IPC/database query per phone number (N+1 problem). For a list of 50 SMS messages, this meant 50 separate IPC calls, causing significant UI lag or processing delay.
📊 Measured Improvement:
ceil(N/50)queries. For typical use cases (e.g., inbox list), this reduces queries from ~20-50 to 1.ExternalContentBridgeTest.javausing Robolectric and a mock ContentProvider to confirm that looking up 3 contacts results in exactly 1 query instead of 3.PR created automatically by Jules for task 17496235591141227007 started by @xRahul