⚡ Remove blocking thread sleep in database retry loop #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented performance optimization in
DatabaseBridge.javaby removing a manual retry loop withThread.sleep(10).Why:
The previous implementation blocked the thread (potentially UI or background) for up to 100ms when database insertions failed (e.g. transient errors or logic errors), causing unnecessary delays. SQLite handles contention internally or via transactions.
Measured Improvement:
Added a new unit test
DatabaseBridgeTestusing Robolectric.Changes:
whileretry loop ininsertIntoSms.sleepTenMillishelper method.robolectric,mockito-core, andmockito-inlinetoapp/build.gradleto support the new test.PR created automatically by Jules for task 8006785426189791653 started by @xRahul