Modernize Android Project and Add CI/CD #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate all Java code and Layouts to AndroidX and Material Components. - Update Gradle to 8.5 and Android Gradle Plugin to 8.2.0. - Update `compileSdk` and `targetSdk` to 34. - Fix D8/R8 build failures by excluding `listenablefuture` and adjusting Java compatibility. - Update `styles.xml` to use `Theme.MaterialComponents` and define `preferenceTheme`. - Add GitHub Actions workflows for CI (Build & Test) and Release. - Update `colors.xml` with missing resources. - Fix `AndroidManifest.xml` `exported` attributes for Android 12+ compatibility.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Owner
|
build failed. fix it- android { |
Contributor
Author
I have fixed the lint errors. Specifically, I've updated |
- Safely handle `getColumnIndex` in `ExternalContentBridge.java`. - Use `requireActivity()` instead of `Objects.requireNonNull(getActivity())` in `AddCategoryFragment.java`. - Add `uses-feature android:name="android.hardware.telephony" android:required="false"` to `AndroidManifest.xml` to suppress lint error about implicit permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the codebase by migrating to AndroidX, updating the build system to the latest stable versions (Gradle 8.5, AGP 8.2.0), and ensuring compatibility with Android SDK 34 and Java 21 environment.
Key changes:
android.supportlibraries with theirandroidxequivalents in Java and XML files.D8/R8compilation errors by handlinglistenablefutureduplicates.JdkImageTransformissues by usingJavaVersion.VERSION_1_8source compatibility while running on JDK 21.AndroidManifest.xmlto includeandroid:exportedfor activities.styles.xmlto use Material Components theme and fix Settings crash by addingpreferenceTheme.PR created automatically by Jules for task 13992512488256457304 started by @xRahul