Skip to content
This repository was archived by the owner on Jun 21, 2024. It is now read-only.

Conversation

@sanbeg
Copy link

@sanbeg sanbeg commented May 31, 2013

This enabled FINAL_BUILD to suppress those distracting "not precached" warnings, and fixes/suppresses most of the compiler warnings.

@xLAva
Copy link
Owner

xLAva commented Jul 21, 2013

Sorry for my late answer.
The reason why I didn't merge your work yet is, that there are a lot of changes and I didn't have time to check them out.
The "final_build_flag" troubles me the most, because it changes a lot and I have to retest a lot of the game to see if there are new bugs because of this.
I'm not sure when I have time to do this. It might take some time.

@sanbeg
Copy link
Author

sanbeg commented Jul 21, 2013

On 07/21/2013 01:28 PM, xLAva wrote:

Sorry for my late answer.
The reason why I didn't merge your work yet is, that there are a lot
of changes and I didn't have time to check them out.
The "final_build_flag" troubles me the most, because it changes a lot
and I have to retest a lot of the game to see if there are new bugs
because of this.
I'm not sure when I have time to do this. It might take some time.


Reply to this email directly or view it on GitHub
#8 (comment).

Thanks for the update. I've already played through a few levels with
this branch; Other than those distracting "not precached" messages, the
only changes I've seen due to the final_build_flag are the change in the
console bindings, which I've already fixed; and that it seems to
suppress the message when changing the lightsaber style, which I
recently discovered and haven't had a change to look into yet. It
should be just as easy to create a new flag to disable the debug
messages; from the name of the flag I was thinking it may suppress other
debug messages as well, but I haven't found any yet. So I can add a new
flag for the precached messages and disable the final_build_flag if that
would help.

The other changes were just to suppress compiler warnings; I think most
of them were from a local reimplementation of a gcc builtin.

@xLAva
Copy link
Owner

xLAva commented Jul 22, 2013

A new flag would be great.
I could merge your changes sooner and there would be time to check out the final_build flag and re-test the game later.

….." messages

without affecting console bindings, supresses lightsaber style messages, etc.
@sanbeg
Copy link
Author

sanbeg commented Aug 9, 2013

On 07/22/2013 11:43 AM, xLAva wrote:

A new flag would be great.
I could merge your changes sooner and there would be time to check out
the final_build flag and re-test the game later.


Reply to this email directly or view it on GitHub
#8 (comment).

OK, I added the new flag to the branch in the pull request.

@xLAva
Copy link
Owner

xLAva commented Aug 12, 2013

Thx for the change. I pulled it and it is in review now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants