Skip to content

Fix strings.Builder type assertion panic in sync.Pool #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-stp merged 1 commit into from
Aug 5, 2025
Merged

Fix strings.Builder type assertion panic in sync.Pool #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/core/download_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,14 +596,14 @@ func (dm *DownloadManager) downloadCallback(item *WorkItem) error {

// Get a string builder from the pool
sbInterface := dm.stringPool.Get()
sb := sbInterface.(strings.Builder)
sb := sbInterface.(*strings.Builder)
sb.Reset()
sb.Grow(entriesCount * 512) // Pre-allocate approximate space

// Build output in memory first
for i, entry := range entriesResponse.Entries {
certIndex := item.Start + int64(i)
fmt.Fprintf(&sb, "%d,%s,%s\n", certIndex, entry.LeafInput, entry.ExtraData)
fmt.Fprintf(sb, "%d,%s,%s\n", certIndex, entry.LeafInput, entry.ExtraData)
}

// Get the built string
Expand Down
Loading