Open
Conversation
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
m-dango
force-pushed
the
error-summary-proc
branch
from
2104ddf to
bcc7ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the form builder, we found that we were unable to translate the default error summary heading in the same way we had done for the submit button e.g.
-> { I18n.t('translation') }.This change allows the error summary to call procs in the same way the submit element does.
Additionally, it adds a test case for proc support on the submit button.