Skip to content

Add multithreading via rayon#50

Open
AroneyS wants to merge 2 commits intomainfrom
add-multithreading
Open

Add multithreading via rayon#50
AroneyS wants to merge 2 commits intomainfrom
add-multithreading

Conversation

@AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented Dec 10, 2024

Had some issues since the parse_fastx_file reader isn't an iterator for some reason, so might be a bit clumsy.

Should I add a test that actually uses multiple threads?

@AroneyS AroneyS requested a review from wwood December 10, 2024 21:59
@wwood
Copy link
Owner

wwood commented Dec 10, 2024 via email

@AroneyS
Copy link
Collaborator Author

AroneyS commented Dec 11, 2024

I tried running appraise using PATH="/home/aroneys/src/smafa/target/release:$PATH" singlem appraise
It took longer. 10h:36m for base, 10h:56m for dev version

Do you have a large-scale test for smafa directly?

@AroneyS
Copy link
Collaborator Author

AroneyS commented Dec 12, 2024

With 600k sequences:
1 thread - 30 seconds
64 threads - 8 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants