Open
Conversation
Owner
|
Yes please. Can you also check it is faster and this isn't for nothing?
-\-------------
Ben Woodcroft
Group leader, Centre for Microbiome Research, QUT
…________________________________
From: Samuel Aroney ***@***.***>
Sent: Wednesday, December 11, 2024 7:59:31 AM
To: wwood/smafa ***@***.***>
Cc: Ben J Woodcroft ***@***.***>; Review requested ***@***.***>
Subject: Re: [wwood/smafa] Add multithreading via rayon (PR #50)
@AroneyS<https://github.com/AroneyS> requested your review on: #50<#50> Add multithreading via rayon.
―
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAADX5CF564SQFWCXIGWIT32E5P4HAVCNFSM6AAAAABTMEBWBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGYYDOOJVHE3DANI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Collaborator
Author
|
I tried running appraise using Do you have a large-scale test for smafa directly? |
Collaborator
Author
|
With 600k sequences: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some issues since the parse_fastx_file reader isn't an iterator for some reason, so might be a bit clumsy.
Should I add a test that actually uses multiple threads?