Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the S2Generator package to version 0.0.9 and includes several improvements and fixes to the augmentation module and its tests. The main changes involve correcting naming inconsistencies, updating function signatures and return values, and ensuring that the tests align with these updates.
Augmentation module improvements:
empirical_model_modulationtoempirical_mode_modulationin both the import statements and the__all__list. [1] [2]amplitude_modulationfunction to return only the modulated series, removing the second return value.Testing updates:
test_amplitude_modulationto use the newamplitude_meanandamplitude_variationparameters instead ofmin_modulationandmax_modulation, and adjusted the function call accordingly.test_frequency_perturbationto use the correcttime_seriesparameter name and argument order in the function call.empirical_mode_modulation,wiener_filter,add_linear_trend,time_series_mixup) in the test suite.Versioning:
setup.pyands2generator/__init__.py. [1] [2]Minor code cleanup:
val_difffor multivariate input handling.