fix(deps): upgrade eslint and plugins to 9.39.4

.github/workflows/lint.yml

@@ -9,12 +9,12 @@ jobs:
         name: ESLint
         runs-on: ubuntu-latest
         steps:
-            - uses: actions/checkout@v2
-            - name: Install node v14
-              uses: actions/setup-node@v2
+            - uses: actions/checkout@v4
+            - name: Install node v24
+              uses: actions/setup-node@v4
               with:
-                  node-version: '14'
+                  node-version: '24'
             - name: Install dependencies
               run: npm install
             - name: Run ESLint
-              run: ./node_modules/.bin/eslint .
+              run: npm run lint

eslint.config.mjs

@@ -0,0 +1,55 @@
+import globals from 'globals';
+import pluginEslintJs from '@eslint/js';
+import pluginMocha from 'eslint-plugin-mocha';
+import configEslintConfigPrettier from 'eslint-plugin-prettier/recommended';
+
+export default [
+    pluginEslintJs.configs.recommended,
+    {
+        name: 'whatsapp-web.js/default/rules',
+        plugins: {
+            mocha: pluginMocha,
+        },
+        languageOptions: {
+            // // TODO: consider moving to:
+            // ecmaVersion: 2025,
+            ecmaVersion: 2022,
+
+            globals: {
+                ...globals.browser,
+                ...globals.commonjs,
+                ...globals.es6,
+                ...globals.node,
+
+                Atomics: 'readonly',
+                SharedArrayBuffer: 'readonly',
+            },
+        },
+        rules: {
+            'no-unused-vars': [
+                'error',
+                {
+                    // TODO: args can be uncommented, but there is code, that causes lint-errors
+                    // args: 'all',
+                    vars: 'all',
+                    caughtErrorsIgnorePattern: '^ignoreError',
+                },
+            ],
+        },
+    },
+    {
+        name: 'whatsapp-web.js/default/ignores',
+        ignores: [
+            'node_modules',
+            'dist',
+            'coverage',
+            'docs',
+            '*.min.js',
+            '.wa-version',
+            '.wwebjs_auth',
+            '.wwebjs_cache',
+        ],
+    },
+    pluginMocha.configs.recommended,
+    configEslintConfigPrettier,
+];

example.js

@@ -119,6 +119,7 @@ client.on('message', async (msg) => {
             await client.acceptInvite(inviteCode);
             msg.reply('Joined the group!');
         } catch (e) {
+            console.error(e);
             msg.reply('That invite code seems to be invalid.');
         }
     } else if (msg.body.startsWith('!addmembers')) {

package.json

@@ -42,18 +42,20 @@
         "puppeteer": "^24.31.0"
     },
     "devDependencies": {
-        "is-ci": "^4.1.0",
         "@commitlint/cli": "^20.4.1",
         "@commitlint/config-conventional": "^20.4.1",
+        "@eslint/js": "^9.39.4",
         "@types/node-fetch": "^2.5.12",
         "chai": "^4.3.4",
         "chai-as-promised": "^7.1.1",
         "dotenv": "^16.0.0",
-        "eslint": "^8.4.1",
+        "eslint": "^9.39.4",
         "eslint-config-prettier": "^10.1.8",
-        "eslint-plugin-mocha": "^10.0.3",
+        "eslint-plugin-mocha": "^11.2.0",
         "eslint-plugin-prettier": "^5.5.5",
+        "globals": "^17.4.0",
         "husky": "^9.1.7",
+        "is-ci": "^4.1.0",
         "jsdoc": "^3.6.4",
         "jsdoc-baseline": "^0.1.5",
         "lint-staged": "^16.2.7",

src/Client.js

@@ -107,6 +107,7 @@ class Client extends EventEmitter {
 
         Util.setFfmpegPath(this.options.ffmpegPath);
     }
+
     /**
      * Injection logic
      * Private function
@@ -322,7 +323,7 @@ class Client extends EventEmitter {
                         await webCache.persist(this.currentIndexHtml, version);
                     }
 
-                    //Load util functions (serializers, helper functions)
+                    // Load util functions (serializers, helper functions)
                     await this.pupPage.evaluate(LoadUtils);
 
                     let start = Date.now();
@@ -2327,7 +2328,7 @@ class Client extends EventEmitter {
                             },
                             participantWids,
                         );
-                } catch (err) {
+                } catch (ignoreError) {
                     return 'CreateGroupError: An unknown error occupied while creating a group';
                 }
 
@@ -2566,7 +2567,7 @@ class Client extends EventEmitter {
                                     meContact,
                                 ));
                     }
-                } catch (error) {
+                } catch (ignoreError) {
                     return false;
                 }
 

src/authStrategies/BaseAuthStrategy.js

@@ -8,6 +8,7 @@ class BaseAuthStrategy {
     setup(client) {
         this.client = client;
     }
+
     async beforeBrowserInitialized() {}
     async afterBrowserInitialized() {}
     async onAuthenticationNeeded() {
@@ -17,6 +18,7 @@ class BaseAuthStrategy {
             failureEventPayload: undefined,
         };
     }
+
     async getAuthEventPayload() {}
     async afterAuthReady() {}
     async disconnect() {}

src/structures/Label.js

@@ -37,6 +37,7 @@ class Label extends Base {
          */
         this.hexColor = labelData.hexColor;
     }
+
     /**
      * Get all chats that have been assigned this Label
      * @returns {Promise<Array<Chat>>}

src/structures/Message.js

@@ -821,6 +821,7 @@ class Message extends Base {
         }
         return undefined;
     }
+
     /**
      * Gets the payment details associated with a given message
      * @return {Promise<Payment>}
@@ -1006,6 +1007,7 @@ class Message extends Base {
 
         return edittedEventMsg && new Message(this.client, edittedEventMsg);
     }
+
     /**
      * Returns the PollVote this poll message
      * @returns {Promise<PollVote[]>}

src/util/Injected/Utils.js

@@ -333,7 +333,7 @@ exports.LoadUtils = () => {
                             .vcardGetNameFromParsed(parsed),
                     };
                 }
-            } catch (_) {
+            } catch (ignoreError) {
                 // not a vcard
             }
         }
@@ -361,7 +361,7 @@ exports.LoadUtils = () => {
                 content = options.buttons.body;
                 caption = content;
             } else {
-                caption = options.caption ? options.caption : ' '; //Caption can't be empty
+                caption = options.caption ? options.caption : ' '; // Caption can't be empty
             }
             buttonOptions = {
                 productHeaderImageRejected: false,
@@ -857,7 +857,7 @@ exports.LoadUtils = () => {
                         .require('WAWebCollections')
                         .WAWebNewsletterCollection.find(chatWid);
                 }
-            } catch (err) {
+            } catch (ignoreError) {
                 chat = null;
             }
         } else {
@@ -1181,7 +1181,7 @@ exports.LoadUtils = () => {
             );
 
             return waveform;
-        } catch (e) {
+        } catch (ignoreError) {
             return undefined;
         }
     };
@@ -1418,7 +1418,7 @@ exports.LoadUtils = () => {
                         return base64Image;
                     }
                 }
-            } catch (error) {
+            } catch (ignoreError) {
                 /* empty */
             }
         }
@@ -1455,7 +1455,7 @@ exports.LoadUtils = () => {
                 rpcResult.value.addParticipant[0]
                     .addParticipantsParticipantAddedOrNonRegisteredWaUserParticipantErrorLidResponseMixinGroup
                     .value.addParticipantsParticipantMixins;
-        } catch (err) {
+        } catch (ignoreError) {
             data.code = 400;
             return data;
         }
@@ -1618,7 +1618,7 @@ exports.LoadUtils = () => {
                     ));
             }
             return result;
-        } catch (err) {
+        } catch (ignoreError) {
             return [];
         }
     };

src/webCache/LocalWebCache.js

@@ -22,7 +22,7 @@ class LocalWebCache extends WebCache {
 
         try {
             return fs.readFileSync(filePath, 'utf-8');
-        } catch (err) {
+        } catch (ignoreError) {
             if (this.strict)
                 throw new VersionResolveError(
                     `Couldn't load version ${version} from the cache`,

src/webCache/WebCache.js

@@ -5,6 +5,7 @@ class WebCache {
     async resolve() {
         return null;
     }
+
     async persist() {}
 }
 

tests/client.js

@@ -351,7 +351,7 @@ END:VCARD`;
             it('can send multiple Contacts as a contact card message', async function () {
                 const contact1 = await client.getContactById(remoteId);
                 const contact2 =
-                    await client.getContactById('5511942167462@c.us'); //iFood
+                    await client.getContactById('5511942167462@c.us'); // iFood
 
                 const msg = await client.sendMessage(remoteId, [
                     contact1,

tests/structures/chat.js

@@ -183,7 +183,7 @@ describe('Chat', function () {
         });
     });
 
-    // eslint-disable-next-line mocha/no-skipped-tests
+    // eslint-disable-next-line mocha/no-pending-tests
     describe.skip('Destructive operations', function () {
         it('can clear all messages from chat', async function () {
             const res = await chat.clearMessages();