fix: getContacts resolving all promisses

[BenyFilho]

Fixing getContacts resolving all promises

Description

Fixing getContacts resolving all promises

Related Issue(s)

Closes #201690

Testing Summary

Test Details

client.on('ready', async () => {
    const contacts = client.getContacts();
    console.log(contacts);
});

Environment

• Machine OS:

Windows 10

• Phone OS:
  Android 11

• Library Version:

1.34.6 - #main branch with recent changes

• WhatsApp Web Version:

2.3000.1036716141

• Browser Type and Version:

Chrome 146.0.7680.178

• Node Version:

18.20.2

Type of Change

• Dependency change (package changes such as removals, upgrades, or additions)
• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Non-code change (documentation, README, etc.)

Checklist

• My code follows the style guidelines of this project.
• All new and existing tests pass (npm test).
• Typings (e.g. index.d.ts) have been updated if necessary.
• Usage examples (e.g. example.js) / documentation have been updated if applicable.

[Adi1231234]

@BenyFilho Nice work, thanks for fixing this!

A few suggestions:

• createWid(contact.id) can be dropped - contact.id is already a Wid on the model (createWid(contact.id) === contact.id). Unlike getContact() where the id comes as a string from Node.
• contact.businessProfile = bizProfile is redundant - Contact.initialize() calls addChild("businessProfile", ...) which links it to the collection. When find() updates the collection, the contact reflects it automatically. Same for new contacts via the change:isBusiness listener.
• Promise.resolve(...) isn't needed - Promise.all handles plain values.
• find() can reject with ServerStatusCodeError - one failed profile would take down the whole Promise.all. Worth adding a .catch().

Suggested version:

window.WWebJS.getContacts = async () => {
    const contacts = window.require('WAWebCollections').Contact.getModelsArray();
    return Promise.all(
        contacts.map(async (contact) => {
            if (contact.isBusiness || contact.isEnterprise) {
                await window.require('WAWebCollections')
                    .BusinessProfile.find(contact.id)
                    .catch(() => {});
            }
            return window.WWebJS.getContactModel(contact);
        })
    );
}

[Adi1231234]

Great! Approved :) @BenyFilho

[themazim]

works as expected.