A couple fixes & an improvement. #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where the script attempts to fetch nonexistent tracks (which you also mentioned in PR wwared#4) by adjusting the regex to not match additional (incorrect) elements on the page. Notably "_tracks" and "[STATION_TITLE]", so it will not attempt to fetch these strings as .mp3 tracks.
Previously had issues with certain track names. As you suspected in your comment on PR wwared#4, it was indeed an encoding issue (: Fixes the issue where track names which contain #, which is not sanitized because it's technically valid within URLs in some cases, as the prefix for a fragment identifier, like when you link someone to an anchored section of a long Wikipedia article - which... just isn't what we want here at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that there are quite a few new/different stations now, but rather than constantly updating a perpetually out-of-date list of stations on the repo, I just modified the script to automatically fetch a list of live stations at runtime. Fixed a couple other known issues as well while I was digging around in there.
Before today I knew ~nothing at all about Perl, so I do hope I haven't done anything too terribly incorrectly.