Scheduler #270

trmccormick · 2017-07-06T15:12:43Z

working scheduler ready for code review.

Add two new options to the form to designate as exporting to public, and designate the form as OAI. These are required to properly export metadata to the OAI server. Otherwise we do not know if 1) a form is ready for release to the public, and 2) if a form is supposed to be indexed in the OAI server for ppublic harvisting. Having both options, plus individual exporting options n each record, it allows for fine tuning the automatic OAI harvisting. The exporting class should be updated to make use of export to public. This feature differs from "Production Ready" in that production ready allows staff to enter data into the form. Allow release to public is when the form is ready for exporting as public consumption.

Update git ignore in develop.

Add Public Export and OAI form metadata options

Typo corrections

…tandards Remove spaces around metadata standards

Also, added a fixme comment where there is a logic error that needs to be fixed.

Update the download all files location

Retrieve an object with its IDNO, instead of the system ObjectID

This is provided so that import scripts for other systems ca update MFCS with regards to where the object is viewable by the public.

forms class file should be broken up. It is currently handling two distinct functions 1. building and taking web form submissions 1. handling everything about a "form" A place holder file has been created, called web_forms.php to support the refactoring

This is essential when getting all objects on systems with limited memory. Cache drastically speeds up many operations, but in some cases is not required.

Accepts parameter to exclude metadata objects

1. Add ability to add a public release select box to object forms. 1. Add ability to set the default value of yes/no to public release select 1. add public release to the object create/update forms Note: when this gets merged into master someone will have to update all of the forms and the export forms. Any form with "publicRelease" will need that removed from the form. Any exports that use public release will need to be updated.

This is required because some fields may be tagged for public release, to a local repository, but should not be included in an OAI release. this could be the case, especially, if there are multiple digital object fields. The public release can be utilized to export all digital objects, but then be hidden from OAI and a single URL can be provided for the item.

Oai updates

1. Created new class string utils 1. Added todos for removing, refactoring

MySQL needs updated on the servers

* Add endpoint to pull Object IDNOs that belong to a project

* Add endpoint to pull Object IDNOs that belong to a project * Path correction * Correct $engine variable * Check for existence of project * Sql correction * Correct coppy and paste error * Typo

* Changing JavaScript to reveal fields. * Fix incorrect number of fields on form insert * Display selected option text ... instead of ID number, for select fields in metadata forms * Bug FIx: Correct issue where adding an element to a metadata form would remove it from production

1. addd public url & oai to object view page

working version of scheduler with changes.

ddavisgraphics · 2017-07-07T12:51:22Z

public_html/admin/scheduler/index.php

+
+$tableName = "scheduler";
+$cronsPath = "/vagrant/public_html/crons";
+$s			= new scheduler($cronsPath);


better variable name, $s tells us nothing.

ddavisgraphics · 2017-07-07T12:52:51Z

public_html/admin/scheduler/index.php

+include("../../header.php");
+include("../../includes/classes/scheduler.php");
+
+//Permissions Access


Can this logic be redacted to an include file so that it is not intermixed with the view? If not then it is fine, but thinking about maintainability and future thought we want to keep logic separate from views as much as possible.

ddavisgraphics · 2017-07-07T12:55:50Z

public_html/crons/runcrons.php

+// Turn off EngineAPI template engine
+$engine->obCallback = FALSE;
+
+$sql       = sprintf("SELECT * FROM `scheduler` WHERE `active` = 1 ");


Why is this being sprintf? Your not formatting anything and your not putting any new statements in. A single string should suffice.

removed sprintf.

ddavisgraphics · 2017-07-07T13:01:46Z

public_html/crons/runcrons.php

+
+if ($sqlResult['numrows'] == "0") die($today . " Nothing to do.\n");
+
+while($row = mysql_fetch_array($sqlResult['result'],  MYSQL_ASSOC)) {


Can be written better to remove some conditionals.

while($row = mysql_fetch_array($sqlResult['result'], MYSQL_ASSOC)) { $runjob = ($row['active'] == 1 && row['runnow'] == 1) ? true : false; // verify scheduled job exists if (!file_exists($row['name'])) { notification::notifyAdmins("MFCS Scheduler Run Failure", $row['name'] , "Scheduled Cron Job is missing"); } else { $minuteset = ( ($row['minute'] == date("i")) || ($row['minute'] == '*') ); $hourset = ( ($row['hour'] == date("G")) || ($row['hour'] == '*') ); $dayofmonthset = ( ($row['dayofmonth'] == date("n")) || ($row['dayofmonth'] == '*') ); $monthset = ( ($row['month'] == date("n")) || ($row['month'] == '*') ); $dayofweekset = ( ($row['dayofweek'] == date("w")) || ($row['dayofweek'] == '*') ); $runjob = ($minuteset && $hourset && $dayofmonthset && $monthset && $dayofweekset); } }

ddavisgraphics · 2017-07-07T13:05:21Z

public_html/crons/runcrons.php

+    }
+  }
+
+  if ($runjob) {


Why isn't this being done inside the scheduler class?

ddavisgraphics · 2017-07-07T13:07:00Z

public_html/includes/classes/scheduler.php

@@ -0,0 +1,77 @@
+<?php
+
+class scheduler {


Why are none of the SQL things namespaced in the scheduler class. Even though they may be done using the command line the classes are still available.

ddavisgraphics · 2017-07-07T13:08:21Z

public_html/includes/formDefinitions/form_scheduler.php

+<?php
+
+function defineList($s, $tableName) {
+	$l      = new listManagement($tableName);


$l

What does that mean, be descriptive enough naming your variables that someone can read it in a natural language to get an idea of what is going on with the code.

ddavisgraphics · 2017-07-07T13:10:14Z

public_html/includes/nav.php

            <li><a href="{local var="siteRoot"}admin/metadataSchema/"> <i class="fa fa-angle-double-right"></i> Metadata Schemas </a></li>
            <li><a href="{local var="siteRoot"}admin/obsoleteFileTypes/"> <i class="fa fa-angle-double-right"></i> Obsolete File Types </a></li>
            <li><a href="{local var="siteRoot"}admin/projects/"><i class="fa fa-angle-double-right"></i> Projects</a></li>
            <li><a href="{local var="siteRoot"}admin/readonly/"><i class="fa fa-angle-double-right"></i> Read Only</a></li>


all of the i tags need to be changed to spans. is inaccessible use span. This was probably done before you and you were mimicking what was there, but span is the appropriate usage.

done replaced all i tags to span.

moved several items from runcrons to scheduler class.

set the current folder instead of setting $cronsPath.

MichaelRBond and others added 30 commits December 10, 2016 19:02

Typo corrections

13d8941

Merge pull request #254 from wvulibraries/master

31be9be

Update git ignore in develop.

Merge pull request #250 from wvulibraries/OAIPublicFormOptions

e73f130

Add Public Export and OAI form metadata options

Merge pull request #252 from wvulibraries/TypoCorrections

c663de3

Typo corrections

Fix variable typo

d9a4991

nagios check

b64b06c

nagios check

7333016

Merge pull request #256 from wvulibraries/RemoveSpacesAroundMetadataS…

2ebeba3

…tandards Remove spaces around metadata standards

Change the temporary location where the download all is built

2bef711

Also, added a fixme comment where there is a logic error that needs to be fixed.

syntax

731ce78

Merge pull request #261 from wvulibraries/DownloadAll

63770c9

Update the download all files location

Add objects::getByIDNO()

e0739b5

Retrieve an object with its IDNO, instead of the system ObjectID

Update ACL includes for the API

9001dcb

API for adding a URL to an Object

fcd1a65

This is provided so that import scripts for other systems ca update MFCS with regards to where the object is viewable by the public.

Switched all methods in Objects class to use standard $engine call

2c197c1

Added todo and place-holder file

112343e

forms class file should be broken up. It is currently handling two distinct functions 1. building and taking web form submissions 1. handling everything about a "form" A place holder file has been created, called web_forms.php to support the refactoring

Updated securityConcerns with clarifying information.

b0b5ef9

Changed objects::getObjects() to honor ignoreCache

80b4f8a

This is essential when getting all objects on systems with limited memory. Cache drastically speeds up many operations, but in some cases is not required.

Add method to count all objects in the system.

c24ab96

Accepts parameter to exclude metadata objects

Add column to objects table for publicRelease of objects

5d821e1

CLI Script to convert from previous way of defining publicRelease object

b21d690

Display Public URLs on the object page, in a new tab.

a684672

Merge pull request #263 from wvulibraries/OAIUpdates

6aeffa4

Oai updates

Starting unit testing framework. Update for public release.

2050d08

1. Created new class string utils 1. Added todos for removing, refactoring

readme file for put url API.

d0d22d5

Only display the Public Release select on object forms

e0053ae

Fix typo

82fb25d

MichaelRBond and others added 14 commits April 2, 2017 07:08

Add API Endpoint for getting a URL for an oobject

6f427a7

Increase the length of the objectUrl tables

3c2fb5a

Max length of varchar in version of mysql on servers is 767

16a7c55

MySQL needs updated on the servers

Switch from utf8 (2 bytes per character) to latin1

8e02de6

Fix path typo

36369ab

Fix for drive usage on dashboard.

e9dbdb9

Projects api endpoint (#264)

6770f92

* Add endpoint to pull Object IDNOs that belong to a project

Projects api endpoint (#266)

1e87dc5

* Add endpoint to pull Object IDNOs that belong to a project * Path correction * Correct $engine variable * Check for existence of project * Sql correction * Correct coppy and paste error * Typo

Add OAI options to the public url tab in Editing

5ce400d

1. addd public url & oai to object view page

Merge remote-tracking branch 'origin/develop' into develop

15f3992

Merge branch 'master' into develop

21782cc

wip (scheduler)

15667dd

working version

40666f8

working version of scheduler with changes.

ddavisgraphics reviewed Jul 7, 2017

View reviewed changes

ddavisgraphics suggested changes Jul 7, 2017

View reviewed changes

trmccormick added 3 commits July 10, 2017 09:56

scheduler

f50e24b

moved several items from runcrons to scheduler class.

updated nav

8dd273e

removed crons path

806f654

set the current folder instead of setting $cronsPath.

ddavisgraphics approved these changes Sep 14, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Scheduler #270

Scheduler #270

Uh oh!

trmccormick commented Jul 6, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

trmccormick Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

ddavisgraphics Jul 7, 2017

Uh oh!

trmccormick Jul 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		if ($sqlResult['numrows'] == "0") die($today . " Nothing to do.\n");

		while($row = mysql_fetch_array($sqlResult['result'], MYSQL_ASSOC)) {

Scheduler #270

Are you sure you want to change the base?

Scheduler #270

Uh oh!

Conversation

trmccormick commented Jul 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants