Skip to content

Handle empty string in ACSV::Detect.separator #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Slike9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle empty string in ACSV::Detect.separator #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/acsv/detect/separator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ def self.separator(file_or_data)
firstline = file_or_data.readline
file_or_data.seek(position)
else
return nil if file_or_data.empty?

firstline = file_or_data.split("\n", 2)[0]
end

separators = SEPARATORS.map{|s| s.encode(firstline.encoding)}
sep = separators.map {|x| [firstline.count(x),x]}.sort_by {|x| x[0]}.last
sep[0] == 0 ? nil : sep[1].encode('ascii')
Expand Down
3 changes: 3 additions & 0 deletions spec/acsv/separator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,8 @@
end
end

it 'handles empty string' do
expect(ACSV::Detect.separator('')).to be_nil
end
end
end