Skip to content

Conversation

@Aenimus
Copy link
Member

@Aenimus Aenimus commented Feb 2, 2026

@coderabbitai summary

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.51%. Comparing base (fd9302f) to head (7e13b9d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2484       +/-   ##
===========================================
- Coverage   63.20%   36.51%   -26.70%     
===========================================
  Files         296      944      +648     
  Lines       41480   123501    +82021     
  Branches     4312     5063      +751     
===========================================
+ Hits        26219    45095    +18876     
- Misses      15239    76863    +61624     
- Partials       22     1543     +1521     

see 652 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-310f4bd832f04e56f36a5cb5029c4ffe1850877a

@@ -278,8 +282,10 @@ export class FederationFactory {
parentTagDataByTypeName = new Map<TypeName, ParentTagData>();
persistedDirectiveDefinitionByDirectiveName = new Map<DirectiveName, DirectiveDefinitionNode>([
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These directives are not persisted in the client schema, so they don't need to go in here.

});

test('that multiple @listSize directives on different fields are preserved in federated schema', () => {
const { federatedGraphSchema } = federateSubgraphsSuccess(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check the client schema (which should not contain the directives)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants