-
Notifications
You must be signed in to change notification settings - Fork 208
feat(composition): support @cost and @listSize #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(composition): support @cost and @listSize #2484
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2484 +/- ##
===========================================
- Coverage 63.20% 36.51% -26.70%
===========================================
Files 296 944 +648
Lines 41480 123501 +82021
Branches 4312 5063 +751
===========================================
+ Hits 26219 45095 +18876
- Misses 15239 76863 +61624
- Partials 22 1543 +1521 🚀 New features to boost your workflow:
|
Router image scan passed✅ No security vulnerabilities found in image: |
| @@ -278,8 +282,10 @@ export class FederationFactory { | |||
| parentTagDataByTypeName = new Map<TypeName, ParentTagData>(); | |||
| persistedDirectiveDefinitionByDirectiveName = new Map<DirectiveName, DirectiveDefinitionNode>([ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These directives are not persisted in the client schema, so they don't need to go in here.
| }); | ||
|
|
||
| test('that multiple @listSize directives on different fields are preserved in federated schema', () => { | ||
| const { federatedGraphSchema } = federateSubgraphsSuccess( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also check the client schema (which should not contain the directives)
@coderabbitai summary
Checklist