Fix semver version check for requests #657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a duplicate of #650 which IMHO is the standard way of doing this and much simpler |
Author
|
That's great. Any plans to merge #650 and make a release? |
|
I'm not a maintainer so I can't tell you. I submitted #650 when linkcheker broke for us in the matplotlib docs build on Travis CI, I would like to see it merged and a new release too. |
Contributor
|
This was fixed differently in c2ce810. |
|
please reroll this PR in the new organisation here: https://github.com/linkcheck/linkchecker/pulls see #686 for details |
Contributor
|
This PR should be closed since it fixes a bug already fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the check that
requestsversion 2.10.0 >= 2.2.0 fails, since the check is using string comparison instead of numeric.