Use a truecolor terminal shell by default#6
Open
afbjorklund wants to merge 1 commit intowuchihsu:mainfrom
Open
Use a truecolor terminal shell by default#6afbjorklund wants to merge 1 commit intowuchihsu:mainfrom
afbjorklund wants to merge 1 commit intowuchihsu:mainfrom
Conversation
Contributor
Author
|
BTW; it can also do emojis... Just have to output the unicode for it:
Like so: https://github.com/JessTaDa/display-emoji-in-terminal-ruby |
wuchihsu
reviewed
Dec 18, 2025
| defer c.sessIn.Close() | ||
|
|
||
| if err := c.sess.RequestPty("xterm", wdSize.High, wdSize.Width, terminalModes); err != nil { | ||
| if err := c.sess.RequestPty("xterm-256color", wdSize.High, wdSize.Width, terminalModes); err != nil { |
Owner
There was a problem hiding this comment.
Could we have a fallback to 'xterm'?
| } | ||
| if err := c.sess.Setenv("COLORTERM", "truecolor"); err != nil { | ||
| log.Println("bridgeWSAndSSH: session.Setenv:", err) | ||
| return |
Owner
There was a problem hiding this comment.
If it fails, could we log the warning but continue establishing the shell?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like so:
See https://github.com/busyloop/lolcat for demo (or charm.sh)
Closes #5