Skip to content

Conversation

@KethniiImasha
Copy link

@KethniiImasha KethniiImasha commented Jan 11, 2026

…docs

Purpose

Fix minor documentation issues in the Asgardeo Identity Governance API specification.

This includes:

  • Correcting spelling errors (recievedreceived, occuredoccurred) in the Error schema.
  • Fixing incorrect path placeholders in example curl URLs ({catergory-id}{category-id}).

These changes improve clarity, accuracy, and developer experience when using the API docs.

Related PRs

None (first PR for this branch).

Test environment

Docs-only change; verified visually in the YAML file.

Security checks

Summary by CodeRabbit

  • Documentation
    • Corrected path-parameter typos in API examples (curl samples) so endpoints reference "category-id" consistently.
    • Clarified API error schema descriptions for clearer, more accurate error code and error description text.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Walkthrough

Updated the identity-governance OpenAPI document: corrected path parameter name from catergory-id to category-id across endpoints and revised Error schema descriptions for Error.code and Error.description.

Changes

Cohort / File(s) Summary
Documentation updates
en/asgardeo/docs/apis/restapis/identity-governance.yaml
Fixed path parameter typo catergory-idcategory-id in multiple endpoints (GET, PATCH variants, connector routes) and updated Error schema descriptions: Error.code.description → "The error code received." and Error.description.description → "The description of the error that occurred."

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a tweak, a doc refined,
I chased a misspelt path and mind,
"catergory" now finds its right,
"received" and "occurred" fixed tonight,
✨📜

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Docs Improvement: Identity Governance API' is vague and generic, using a broad qualifier without specifying the actual improvement made. Consider a more specific title like 'Fix typos in Identity Governance API documentation' to clearly convey the nature of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description follows the required template with all major sections completed: Purpose clearly describes the fixes, Related PRs confirms none, Test environment documents the docs-only nature, and all Security checks are marked complete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
en/asgardeo/docs/apis/restapis/identity-governance.yaml (1)

73-73: Complete the path placeholder typo fixes mentioned in the commit message.

The commit message indicates "incorrect path placeholders" were fixed, but the typo {catergory-id} (should be {category-id}) still appears in multiple curl example URLs on lines 73, 104, 130, 182, and 209. This inconsistency could confuse API users who copy these examples.

📝 Suggested fixes for remaining path placeholder typos

Line 73:

-'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{catergory-id}' \
+'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{category-id}' \

Line 104:

-'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{catergory-id}/connectors' \
+'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{category-id}/connectors' \

Line 130:

-'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{catergory-id}/connectors' \
+'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{category-id}/connectors' \

Line 182:

-'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{catergory-id}/connectors/{connector-id}' \
+'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{category-id}/connectors/{connector-id}' \

Line 209:

-'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{catergory-id}/connectors/{connector-id}' \
+'https://api.asgardeo.io/t/{organization-name}/api/server/v1/identity-governance/{category-id}/connectors/{connector-id}' \

Also applies to: 104-104, 130-130, 182-182, 209-209

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1475b93 and ffa2e50.

📒 Files selected for processing (1)
  • en/asgardeo/docs/apis/restapis/identity-governance.yaml
🔇 Additional comments (2)
en/asgardeo/docs/apis/restapis/identity-governance.yaml (2)

488-488: LGTM! Spelling correction improves documentation quality.

The typo fix "recieved" → "received" is correct and enhances the professionalism of the API documentation.


496-496: LGTM! Spelling correction improves documentation quality.

The typo fix "occured" → "occurred" is correct and enhances the professionalism of the API documentation.

@KethniiImasha
Copy link
Author

KethniiImasha commented Jan 11, 2026 via email

@KethniiImasha
Copy link
Author

Thank you for the review! All occurrences of {catergory-id} have been replaced with {category-id} in the example URLs. Please let me know if any are still missed.

@KethniiImasha
Copy link
Author

Hi @team,
Could someone please review and approve this PR?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant