Conversation
wsnk
requested changes
Feb 15, 2025
| assert {"a": 1, "b": 2} == DictContains({}) | ||
|
|
||
|
|
||
| def test_anyof(): |
Owner
There was a problem hiding this comment.
Well, it should be vice versa =)
Actual value should be equal to one of "AnyOf". Not "AnyOf" is equal to one of the actual.
I.e. it should do:
assert 1 == AnyOf(1, 2, 3)
| assert [8, "a", 3.5] == SimilarList(["a", 8, 3.5]) | ||
| assert [8, "a", 3.5] == SimilarList([3.5, 8, "a"]) | ||
| assert [8, "a", 3.5] != SimilarList([3.5, 9, "a"]) | ||
| assert [8, "a", 3.5] != SimilarList([3.5, 8, "a", 10]) |
Owner
There was a problem hiding this comment.
Add also test(s) with empty lists, as it's usually a special corner case
| return repr(self.value) | ||
|
|
||
|
|
||
| class SimilarList: |
Owner
There was a problem hiding this comment.
I'd rather name it as "unorderd list" for this particular case.
wsnk
reviewed
Feb 15, 2025
| def __init__(self, value): | ||
| self.value = value | ||
|
|
||
| def __eq__(self, other): |
Owner
There was a problem hiding this comment.
Instead of implementing its own __eq__, we need to inherite from Matcher and implement _match(self, other). Check, how DictContains works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.