CMake Ensure defines for ungrib reading tools are set for all languages#280
Open
islas wants to merge 1 commit intowrf-model:developfrom
Open
CMake Ensure defines for ungrib reading tools are set for all languages#280islas wants to merge 1 commit intowrf-model:developfrom
islas wants to merge 1 commit intowrf-model:developfrom
Conversation
When building WPS with CMake, certain compile definitions such as `USE_JPEG2000`` and `USE_PNG`` were only being set for Fortran files. This caused issues when compiling C files that also needed these definitions. The fix involves adding these definitions globally, ensuring they are available for all source files regardless of language. The files that are specifically affected during compilation with these changes are under the ungrib/src/ngl/g2 directory: * dec_jpeg2000.c / enc_jpeg2000.c * dec_png.c / enc_png.c This change does not impact the make build process, and only affects CMake builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building WPS with CMake, certain compile definitions (
USE_JPEG2000andUSE_PNG) were only being set for Fortran files. This caused issues when compiling C files that also needed these definitions.The fix involves adding these definitions globally, ensuring they are available for all source files regardless of language. The files that are specifically affected during compilation with these changes are under the ungrib/src/ngl/g2 directory:
This change does not impact the make build process, and only affects CMake builds.
Addresses issue #279