(enh) adds Process.exec(cmd, [args], [cwd],[env])#94
(enh) adds Process.exec(cmd, [args], [cwd],[env])#94joshgoebel wants to merge 13 commits intowren-lang:mainfrom
Conversation
|
Notes: |
|
I think I know what you mean about tests now... I'd wager the python stuff doesn't understand the structure of the Wren code so while you can have the different branches doing slightly different things, the output needs to match for every single platform? Anyways, the tests still feel messy to me, but they cover the most basic cases. Since we don't need absolute paths I wager they likely work on other *nix as well, hence my making We just need to find equivalencies on Windows. All tests pass for me here on OS X. Issues:
I didn't spend too much time trying to understand the python test runner. I stopped when I had the basic tests cases covered. I'm pretty frustrated with the testing tooling and think it'd be much nicer if we picked any one of the Wren testing frameworks instead and switched. Perhaps a topic for another time. |
|
rebased on main |
src/module/os.c
Outdated
| { | ||
| free(env); | ||
| index += 1; | ||
| env = data->options.args[index]; |
There was a problem hiding this comment.
Fixed in later commit.
|
Ruby, Removing |
Uh oh!
There was an error while loading. Please reload this page.