Draft
Conversation
6e3168d to
830129d
Compare
Contributor
Author
|
Updated: Attempts to properly clean up fully before stopping completely. This also improves scheduler error handling which also uses |
Contributor
Author
|
Converting to draft, seems obvious now this needs more work. |
Contributor
Author
|
Fairly confident this works: The flow:
I can update my patch here if there is agreement this is a viable solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This is needed for usage with terminal scripting, CI (test suites), build systems, etc. Being able to return an error code (without purposely crashing) is necessary for many different uses cases.
I think this is sufficient because freeVm() does all the
cleanup calling ioShutdown and schedulerShutdown(). What
I'm not 100% sure of is if I need to address this:
If so I think I can add it fairly easily.I've fully implemented closing all handles now.Ref: libuv/libuv#709