Open
Conversation
List of implemented commands:
- `.clear` - clears screen
- `.exit` - exits REPL
- `.help` - prints help message
- `.save` - saves all evaluated commands in the current REPL session
to a file
Implement Repl#clear & Repl#close methods.
joshgoebel
reviewed
Apr 26, 2021
| for (entry in COMMANDS) { | ||
| var command = entry[0] | ||
| var line = _line.trimStart() | ||
| if (command.startsWith(line)) { |
Contributor
There was a problem hiding this comment.
Why not just check equality?
Contributor
There was a problem hiding this comment.
My bad, this is inside completion, I didn't have enough context in the diff. :)
joshgoebel
approved these changes
Apr 26, 2021
Contributor
joshgoebel
left a comment
joshgoebel
left a comment
There was a problem hiding this comment.
I think .save should perhaps be auto-magic. (see #70) but otherwise this looks pretty clean.
Contributor
|
@vladimyr If the CLI auto-remembered history from the prior sessions would that have prevented you from adding |
Contributor
|
I think this has the right idea (of adding some basic editor commands). Ruby, would this be more mergeable if we ripped out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of implemented commands:
.clear- clears screen.exit- exits REPL.help- prints help message.save- saves all evaluated commands in the current REPL session to a file