Use uname(3) to get platform name via POSIX API#144
Open
RealDeuce wants to merge 3 commits intowren-lang:mainfrom
Open
Use uname(3) to get platform name via POSIX API#144RealDeuce wants to merge 3 commits intowren-lang:mainfrom
RealDeuce wants to merge 3 commits intowren-lang:mainfrom
Conversation
Since __unix__ implies POSIX, and even POSIX.1 included uname(3), we can simply ask a POSIX system what the system name is. While some compilers don't define __unix__ for some platforms (ie: clang on macOS), it appears that every platform that defines __unix__ at least has the POSIX unistd.h header.
Author
|
The |
Despite the test no longer running, the return value was still checked by the test script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since unix implies POSIX, and even POSIX.1 included uname(3), we can simply ask a POSIX system what the system name is.
While some compilers don't define unix for some platforms (ie: clang on macOS), it appears that every platform that defines unix at least has the POSIX unistd.h header.