Skip to content

Conversation

@jwidavid
Copy link

@jwidavid jwidavid commented May 30, 2024

This is designed to be one step toward completing the MVP feature here: #253

Changes:

  • Uses the authenticated cookies in a subsequent scan
  • Adds unit tests and error handling

Testing instructions can be found in the above PR as well.

Additional testing

  • Try causing an uncaught exception.
    • Manually close the popup browser window before continuing
    • Don't authenticate but press enter in the terminal to continue

@jwidavid jwidavid self-assigned this May 30, 2024
@coveralls
Copy link

coveralls commented May 30, 2024

Coverage Status

coverage: 98.84% (-0.2%) from 99.045%
when pulling 77ab7f0 on add/saml-cookie-management
into 6ad3fbf on add/saml-authentication.

@jwidavid jwidavid marked this pull request as ready for review May 30, 2024 13:43
Copy link
Contributor

@miguelxpn miguelxpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as advertised too!

@jwidavid jwidavid merged commit 3656bf0 into add/saml-authentication May 31, 2024
@jwidavid jwidavid deleted the add/saml-cookie-management branch May 31, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants