Skip to content

Add SAML flag to follow the redirect and open the browser #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwidavid merged 1 commit into from
May 30, 2024
Merged

Add SAML flag to follow the redirect and open the browser #255

jwidavid merged 1 commit into from
May 30, 2024

Conversation

@jwidavid
Copy link

@jwidavid jwidavid commented May 28, 2024 •
edited
Loading

This is designed to be one step toward completing the MVP feature here: #253

Changes:

  • Adds the flag to expect SAML
  • Adds a new dependency that will allow us to interact with a regular browser (and also supports headless browser as well)
  • Collects the cookies that we will be able to use in the next task

Testing instructions can be found in the above PR as well.

@jwidavid jwidavid self-assigned this May 28, 2024
@coveralls
Copy link

coveralls commented May 28, 2024

Coverage Status

coverage: 99.045% (-0.9%) from 99.926%
when pulling 9c9dd0b on add/saml-flag
into fb7e333 on add/saml-authentication.

@jwidavid jwidavid marked this pull request as ready for review May 28, 2024 04:31
@jwidavid jwidavid requested review from a team and removed request for a team May 28, 2024 04:31
miguelxpn
miguelxpn approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@miguelxpn miguelxpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as advertised!

@jwidavid jwidavid merged commit 6ad3fbf into add/saml-authentication May 30, 2024
@jwidavid jwidavid deleted the add/saml-flag branch May 30, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miguelxpn miguelxpn miguelxpn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jwidavid jwidavid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jwidavid @coveralls @miguelxpn