[wpinet] Add mDNS discovery tests and fix mDNS JNI bugs#8682
Open
mcm001 wants to merge 26 commits intowpilibsuite:2027from
Open
[wpinet] Add mDNS discovery tests and fix mDNS JNI bugs#8682mcm001 wants to merge 26 commits intowpilibsuite:2027from
mcm001 wants to merge 26 commits intowpilibsuite:2027from
Conversation
Contributor
Author
|
We can also retarget this at main if you'd prefer |
Gold856
requested changes
Mar 16, 2026
Member
Gold856
left a comment
There was a problem hiding this comment.
Lot of printfs. Should those be printlns?
wpinet/src/test/java/org/wpilib/net/MulticastServiceAnnouncerTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
It looks like none of our runners include avahi-daemon, leading to these test failures? https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md Would we prefer
|
sciencewhiz
reviewed
Mar 17, 2026
Contributor
Author
|
I need some help understanding what to do about the tsan warnings in https://github.com/wpilibsuite/allwpilib/actions/runs/23174224436/job/67332769813?pr=8682 -- are these real/something we need to address? windows ci failed because of a flake in |
431daa7 to
13ba7d4
Compare
Gold856
reviewed
Mar 19, 2026
Contributor
Author
|
Blocked on wpilibsuite/docker-images#71 |
Gold856
requested changes
Mar 20, 2026
wpinet/src/test/java/org/wpilib/net/MulticastServiceAnnouncerTest.java
Outdated
Show resolved
Hide resolved
Gold856
reviewed
Mar 20, 2026
Gold856
requested changes
Mar 21, 2026
Gold856
requested changes
Mar 21, 2026
Gold856
requested changes
Mar 22, 2026
Gold856
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8681 we discovered that multicast service types need to be valid (end with _tcp or _udp), or else errors are silently swallowed. Let's make our C++ unit test use a valid name and also check that it works. I think if we should/shouldn't do this is up for debate still.
I also discovered two bugs in the JNI code that lead to incorrect results being returned