Skip to content

Fix broken tests #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernilambar merged 1 commit into from
Sep 5, 2025
Merged

Fix broken tests #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions features/check-core-update.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ Feature: Check whether WordPress is up to date
Given a WP install
And I run `wp theme delete --all --force`
And I run `wp theme install twentytwelve --activate`
And I run `wp core download --version=4.1.30 --force`
And I run `wp core download --version=5.9.10 --force`

# This version of WP throws a PHP notice.
When I try `wp core update --minor`
When I run `wp core update --minor`
Then STDOUT should contain:
"""
Success: WordPress updated successfully.
Expand Down
25 changes: 13 additions & 12 deletions features/check-plugin-status.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,26 @@ Feature: Check the status of a plugin

Scenario: Basic usage
Given a WP install
And I run `wp plugin install https://github.com/wp-cli/sample-plugin/archive/refs/heads/master.zip`
And a config.yml file:
"""
plugin-akismet-active:
class: WP_CLI\Doctor\Check\Plugin_Status
options:
name: akismet
status: active
plugin-hello-uninstalled:
plugin-sample-plugin-uninstalled:
class: WP_CLI\Doctor\Check\Plugin_Status
options:
name: hello
name: sample-plugin
status: uninstalled
"""

When I try `wp doctor check --all --config=config.yml`
Then STDOUT should be a table containing rows:
| name | status | message |
| plugin-akismet-active | error | Plugin 'akismet' is 'inactive' but expected to be 'active'. |
| plugin-hello-uninstalled | error | Plugin 'hello' is 'inactive' but expected to be 'uninstalled'. |
| name | status | message |
| plugin-akismet-active | error | Plugin 'akismet' is 'inactive' but expected to be 'active'. |
| plugin-sample-plugin-uninstalled | error | Plugin 'sample-plugin' is 'inactive' but expected to be 'uninstalled'. |
And STDERR should contain:
"""
Error: 2 checks report 'error'.
Expand All @@ -48,23 +49,23 @@ Feature: Check the status of a plugin

When I try `wp doctor check --all --config=config.yml`
Then STDOUT should be a table containing rows:
| name | status | message |
| plugin-akismet-active | success | Plugin 'akismet' is 'active' as expected. |
| plugin-hello-uninstalled | error | Plugin 'hello' is 'inactive' but expected to be 'uninstalled'. |
| name | status | message |
| plugin-akismet-active | success | Plugin 'akismet' is 'active' as expected. |
| plugin-sample-plugin-uninstalled | error | Plugin 'sample-plugin' is 'inactive' but expected to be 'uninstalled'. |
And STDERR should contain:
"""
Error: 1 check reports 'error'.
"""
And the return code should be 1

When I run `wp plugin delete hello`
When I run `wp plugin delete sample-plugin`
Then STDOUT should not be empty

When I run `wp doctor check --all --config=config.yml`
Then STDOUT should be a table containing rows:
| name | status | message |
| plugin-akismet-active | success | Plugin 'akismet' is 'active' as expected. |
| plugin-hello-uninstalled | success | Plugin 'hello' is 'uninstalled' as expected. |
| name | status | message |
| plugin-akismet-active | success | Plugin 'akismet' is 'active' as expected. |
| plugin-sample-plugin-uninstalled | success | Plugin 'sample-plugin' is 'uninstalled' as expected. |

Scenario: Invalid status registered
Given a WP install
Expand Down
Loading