Skip to content

Wait for services to be healthy #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mbrodala wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Wait for services to be healthy #39

mbrodala wants to merge 1 commit into from

Conversation

@mbrodala
Copy link

@mbrodala mbrodala commented Dec 11, 2024

Fixes #38

@mbrodala mbrodala mentioned this pull request Dec 11, 2024
Draft
@mbrodala
Copy link
Author

mbrodala commented Dec 11, 2024

Not exactly sure about the drive-by change in scale() since the docker-rollout script itself currently checks the health status manually. I wonder if this can be dropped if scaling now automatically waits for the additional instances to be healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Initial rollout ignores healthcheck

1 participant

@mbrodala