adt: Combined Alpha Map #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce combined_alpha_map::CombinedAlphaMap for decoding/packing up to 3 terrain layer alpha maps into a single 64×64 RGBA structure. - Flatten McnkChunk.alpha_maps from Vec<Vec<u8>> to a single contiguous Vec<u8> matching on-disk MCAL layout. - Add McnkChunk::get_combined_alpha_map(has_big_alpha, fix_alpha) convenience constructor. - Remove legacy alpha conversion path (convert_alpha_maps) from mcnk_converter; now alpha data is passed through unchanged. - Update ADT builder to flatten per-layer alpha maps directly when constructing chunks. - Adjust MCNK writer to emit the flattened alpha buffer in one shot. - Simplify reader logic: read raw MCAL payload once (no per-layer slicing) and defer interpretation to CombinedAlphaMap. - Export CombinedAlphaMap via crate root. - Comprehensive unit tests for alpha ingestion.
Member
|
This looks nicely done to me, so thanks very much for that. I will merge this for now, and spend a wee bit of time later to see if I can get this checked for later ADT versions. |
danielsreichenbach
merged commit b78435c
into
wowemulation-dev:main
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combined_alpha_map::CombinedAlphaMapfor decoding/packing up to 3 terrain layer alpha maps into a single 64×64 RGBA structure.McnkChunk.alpha_mapsfromVec<Vec<u8>>to a single contiguousVec<u8>matching on-disk MCAL layout.McnkChunk::get_combined_alpha_map(has_big_alpha, fix_alpha)convenience constructor.convert_alpha_maps) frommcnk_converter; now alpha data is passed through unchanged.CombinedAlphaMap.CombinedAlphaMapvia crate root.