fix: resolve clippy warnings for stable Rust toolchain #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lint configuration to handle unsafe block requirements across Rust versions - Update io::Error creation to use newer io::Error::other() method - Fix CI failures for both MSRV (1.86.0) and stable Rust toolchain The SIMD code now properly handles different lint requirements between Rust versions by allowing both unused_unsafe and unsafe_op_in_unsafe_fn lints, ensuring compatibility across all supported Rust versions.
danielsreichenbach
force-pushed
the
002-fix-mpq-unsafe-blocks
branch
from
e534d9d to
c4fcee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CI failures that are blocking other PRs from merging. The failures were caused by clippy warnings being treated as errors in the stable Rust toolchain.
Changes
1. Fixed unnecessary unsafe blocks in SIMD code
unsafeblocks within already-unsafe functions infile-formats/archives/wow-mpq/src/simd/x86_64.rsunsafe fndon't need additional unsafe blocks2. Updated deprecated IO error creation
io::Error::new(io::ErrorKind::Other, msg)toio::Error::other(msg)inerror.rsTest Plan
✅ All tests pass locally with both toolchains:
cargo test --package wow-mpq --all-featurescargo clippy --package wow-mpq --all-features -- -D warnings(with stable toolchain)Impact
This unblocks CI for all pending PRs, including the WMO parser rewrite that was incorrectly appearing to have failures.