mpq: Store File instead of BufReader #26
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Archive to store a
Fileinstead of aBufReader<File>and createBufReaderinstances on demand inside methods. This relaxes method receivers from&mut selfto&selfwhere possible (e.g., read_file, list), which enables sharing an Archive across threads and reading multiple files concurrently from the same archive. Updated benches, examples, and tests accordingly.No breaking changes. Method receivers changed from
&mut selfto&selfare source compatible; existing code using&mutself can still call these methods.