feat: 40-bit integer support, ESpec parser, and TVFS compliance #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## New Features ### Test Utilities (`test-utils` crate) - Add comprehensive WoW data discovery using environment variables - Support for WOW_CLASSIC_ERA_DATA, WOW_CLASSIC_DATA, WOW_RETAIL_DATA - Automatic fallback to common installation paths (Linux, macOS, Windows) - Convenience macros: `require_wow_data\!()`, `skip_test_if_no_wow_data\!()` - CI-friendly tests that skip gracefully when no WoW data is available ### Documentation Improvements - Add comprehensive testing section to main README - Create detailed test-utils documentation with setup instructions - Add examples showing real WoW data integration - Update ROADMAP.md with completed Phase 2.5 (Architecture Improvements) ## Code Cleanup ### Removed Exploratory/Development Files (33 files) - **Root level**: test-real-data.rs, test-archive-parsing.rs, test_install_manifest.rs, examples/ directory - **BLTE examples**: test_*.rs, investigate_*.rs, analyze_*.rs files (11 files) - **Ribbit examples**: debug_*.rs, check_*.rs, analyze_*.rs, explore_*.rs (12 files) - **Other examples**: exploratory tact-client and tact-parser examples (5 files) - **Tests**: hardcoded path tests in casc-storage (3 files) ### Consolidated Documentation - Streamlined TODO.md by moving completed items to ROADMAP.md - Reduced TODO.md size by ~70% while maintaining important information - Added Phase 2.5 completion to ROADMAP.md (quality checks, serial tests, examples) ## Integration Examples ### New Files - `casc-storage/tests/real_data_integration.rs` - Shows environment variable usage in tests - `casc-storage/examples/list_casc_files.rs` - Example with discovered WoW data - `test-utils/examples/discovery_demo.rs` - Demonstrates data discovery functionality ## Breaking Changes - None - all changes are additive or remove development-only files ## Migration Guide - Tests now use environment variables instead of hardcoded paths - Set WOW_*_DATA environment variables to enable real data testing - All tests skip gracefully if no WoW data is available Closes: Documentation and test data management improvements
- Fix unsafe string slicing in ngdp-bpsv parser to prevent panics - Optimize LRU cache from O(n) to O(1) for common operations - Replace Arc<Mutex<u64>> with AtomicU64 for better performance - Eliminate duplicate logic between BpsvRow types using traits - Refactor repetitive HTTP retry patterns in tact-client - Consolidate mutex-protected data structures to reduce lock contention All tests passing, code ready for release
…mpatibility - Fixed 17 let-chain patterns across casc-storage crate - Fixed clippy lifetime elision warning in ngdp-bpsv - All changes ensure compatibility with Rust 1.86 (MSRV) - Code now compiles cleanly with both 1.86 and 1.89 - All 520+ tests passing on both Rust versions
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the implementation of three critical TACT/NGDP features:
Changes
Core Features
tact-parser/src/ioutils.rsPerformance & Safety Improvements
Arc<Mutex<u64>>withAtomicU64for better performanceCode Quality
Test Plan