Conversation
Zorgen dat deze file alleen werkt onder WSL. Nu komt er een storende boodschap onder Windows gebruikers dat hun programma GREP niet kan vinden en dat klopt.
cjsmeele
reviewed
Apr 17, 2021
| VERSION := V05_00_work_in_progress_2021_01_04 | ||
| WSL := $(strip $(shell grep -qE "(microsoft|Microsoft|WSL)" /proc/version @> /dev/null && printf true)) | ||
| ifeq ($(WSL),true) | ||
| WSL := $(strip $(shell grep -qE "(microsoft|Microsoft|WSL)" /proc/version @> /dev/null && printf true)) |
Contributor
There was a problem hiding this comment.
Dit wordt op deze manier nooit uitgevoerd, tenzij $WSL al op true staat - maar in dat geval heeft het herdefiniëren weinig zin, toch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zorgen dat deze file alleen werkt onder WSL. Nu komt er een storende boodschap onder Windows gebruikers dat hun programma GREP niet kan vinden en dat klopt.
Het veroorzaakt verder gene storing en bij een volgende installatie zijn de studenten er vanaf